-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drm/panel: Fix default values for Waveshare 7.9 inch DSI touchscreen #5565
drm/panel: Fix default values for Waveshare 7.9 inch DSI touchscreen #5565
Conversation
This fixes touchscreen calibration, axis swapping and inversion. As referenced in raspberrypi#5550
I've read the other thread, and I see that it fixes the original user's problem - thanks for that. Could you say something about changing the dimensions to 4096? Otherwise it looks ready to squash and merge. |
I could have sworn I'd commented on this PR previously, but it seems to have disappeared. I'd like to confirm what inversions the Waveshare driver uses for the 7.9" panel. |
Ah, the PR I'd commented on was ilarrain#1 |
With the default config, only a small touch area (about 2x2 cm) was mapped to the whole screen, rendering it unusable. I don't know if it applies to other panels, but at list on mine, @beletruz and @mbhangui, the patch fixed the issues. Maybe other panel sizes also use 4096 on both axis. I have no way to experiment, as this is the only panel I've got.
It is type 5 in the scripts for Wavershare installation, which corresponds to those values, you are correct. I have no way to know if it is an error by the manufacturer, or they are apllying an obscure logic in the overlays or kernel modules, as those are closed source. I just know what values work on my panel (and at least 2 other users).
Sorry about that. I don't know much about git, and ended sending the pull request on the wrong repository. I thought about deleting it, but would have deleted the discussion too. |
I went shopping, and you appear to be right that the display manufacturer (or Waveshare as integrator) have done something very weird in their touch configuration, and plausibly emulated a Goodix touch controller rather than actually using one. @pelwell The second patch is a fixup of the first. I think we can squash the two commits into one whilst merging, dropping the second commit in the process? |
Yes, no, and done. |
kernel: drm/panel: Fix default values for Waveshare 7.9 inch DSI touchscreen See: raspberrypi/linux#5565
kernel: drm/panel: Fix default values for Waveshare 7.9 inch DSI touchscreen See: raspberrypi/linux#5565
This fixes touchscreen calibration, axis swapping and inversion.
As referenced in #5550